Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add support for Nvme/TLS connection #398

Merged
merged 1 commit into from
Oct 5, 2023
Merged

ci: add support for Nvme/TLS connection #398

merged 1 commit into from
Oct 5, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented May 30, 2023

Signed-off-by: Boris Glimcher [email protected]

@glimchb glimchb linked an issue May 30, 2023 that may be closed by this pull request
add support for Nvme/TLS connection #400
Closed
@glimchb glimchb force-pushed the tls branch 4 times, most recently from 590b1b3 to 4d26aac Compare June 1, 2023 22:12
@glimchb glimchb mentioned this pull request Jun 1, 2023
Closed
@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #398 (3ba3eb4) into main (b163364) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   76.05%   76.06%           
=======================================
  Files          37       37           
  Lines        3571     3572    +1     
=======================================
+ Hits         2716     2717    +1     
  Misses        772      772           
  Partials       83       83
Files Coverage Δ
pkg/frontend/nvme_subsystem.go 89.94% <100.00%> (+0.05%) ⬆️
pkg/frontend/transport.go 53.84% <0.00%> (ø)

@glimchb glimchb changed the title ci: add support for TLS connection ci: add support for Nvme/TLS connection Jun 12, 2023
@glimchb
Copy link
Member Author

glimchb commented Jul 6, 2023

waiting on opiproject/opi-api#308

@glimchb glimchb force-pushed the tls branch 2 times, most recently from ff25ceb to b524ac4 Compare July 17, 2023 15:27
This was referenced Sep 28, 2023
Closed
Merged
@glimchb glimchb added the help wanted Extra attention is needed label Sep 28, 2023
glimchb
glimchb commented Sep 28, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@glimchb glimchb marked this pull request as ready for review September 28, 2023 18:12
@glimchb glimchb requested a review from a team as a code owner September 28, 2023 18:12
@glimchb glimchb mentioned this pull request Sep 28, 2023
Closed
glimchb
glimchb commented Sep 28, 2023
View reviewed changes
docker-compose.yml Outdated
@@ -16,6 +16,7 @@ services:
- "9009:9009"
Copy link
Member Author

@glimchb glimchb Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document ports better:

  • 4444 our default spdk no tls before any RPC is available (compose setting for sanity check)
  • 5555 our default spdk with tls before any RPC is available (compose setting for sanity check)
  • 7777 from cmdline arguments when starting bridge, should be replaced by API change feat(storage): frontend traget case API opi-api#375

glimchb
glimchb commented Sep 28, 2023
View reviewed changes
pkg/backend/nvme_path.go Outdated Show resolved Hide resolved
artek-koltun
artek-koltun reviewed Sep 29, 2023
View reviewed changes
pkg/frontend/nvme_controller.go Outdated Show resolved Hide resolved
scripts/tests.sh Outdated Show resolved Hide resolved
@glimchb glimchb added Merge Candidate in the open merge window, next candidate for merge and removed help wanted Extra attention is needed labels Oct 4, 2023
@glimchb glimchb mentioned this pull request Oct 5, 2023
Closed
artek-koltun
artek-koltun approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artek-koltun artek-koltun merged commit b2ec8c1 into opiproject:main Oct 5, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artek-koltun artek-koltun artek-koltun approved these changes

Assignees
No one assigned
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for Nvme/TLS connection
2 participants
@glimchb @artek-koltun