Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPI Device Provisioning and Lifecycle Spec #272

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

dandaly
Copy link
Contributor

@dandaly dandaly commented Jan 16, 2024

As discussed on Jan 16th, 2024 in the weekly forum.

@dandaly dandaly requested a review from a team as a code owner January 16, 2024 20:50
@artek-koltun
Copy link
Contributor

@dandaly please adjust the commit headers according to the conventioanl commit format

commitlint is complaining

config: ./.github/commitlintrc.yml
ecaf597: OPI Device Provisioning and Lifecycle as discussed on Jan 16th, 2024 in the weekly forum.

Signed-off-by: Dan Daly <[email protected]>
Error: ✖ subject may not be empty
Error: ✖ subject may not end with full stop
Error: ✖ type may not be empty
85d4af3: OPI Device Provisioning and Lifecycle Spec linter stuff

Signed-off-by: Dan Daly <[email protected]>
Error: ✖ subject may not be empty
Error: ✖ type may not be empty
Error: commitlint failed

Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a starting point.

@sandersms sandersms merged commit 266ca8c into opiproject:main Jan 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants