Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump/primer upstream #66

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Bump/primer upstream #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a2c508
Release Tracking (#2429)
primer[bot] Jan 4, 2024
6e7b7c2
Bug fix in ActionBar: When collapsed the menu and tooltips aren't vis…
jonrohan Jan 4, 2024
897c821
Merge branch 'bump/primer-upstream-ref' into bump/primer-upstream
HDinger Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-insects-cheat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@openproject/primer-view-components": patch
---

Bug fix in ActionBar: When collapsed the menu and tooltips aren't visible in Firefox
8 changes: 7 additions & 1 deletion app/components/primer/alpha/action_bar_element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ class ActionBarElement extends HTMLElement {
resizeObserver.observe(this)
instersectionObserver.observe(this)

requestAnimationFrame(() => this.update())
requestAnimationFrame(() => {
// This overflow visible is needed for browsers that don't support PopoverElement
// to ensure the menu and tooltips are visible when the action bar is in a collapsed state
// once popover is fully supported we can remove this.style.overflow = 'visible'
this.style.overflow = 'visible'
this.update()
})
}

disconnectedCallback() {
Expand Down
Loading