Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[58256] header and sidebar menu should be hidden while pressing zen mode button #195

Conversation

bsatarnejad
Copy link

@bsatarnejad bsatarnejad commented Oct 22, 2024

What are you trying to accomplish?

Add an event to this button while clicking on it.

Integration

We should listen to this event, then we can add or remove zen-mode class on body element.

Closes https://community.openproject.org/projects/openproject/work_packages/58256/activity

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Add a click event for button, then in core we will listen to this event and show or hide the header and sidebar by adding or removing zen-mode class on body element.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 2cc6cb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bsatarnejad bsatarnejad requested a review from HDinger October 24, 2024 09:25
@bsatarnejad bsatarnejad merged commit 9f66ea9 into main Oct 24, 2024
36 of 39 checks passed
@bsatarnejad bsatarnejad deleted the 58256-header-and-sidebar-menu-should-be-hidden-while-pressing-zen-mode-button- branch October 24, 2024 10:26
@openprojectci openprojectci mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants