Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Allow to configure authentication method through UI #17705

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NobodysNightmare
Copy link
Contributor

Done:

  • Authentication method
  • Nextcloud Audience
  • Properly choose second step during create

TODO:

  • Properly choose step after NC audience
  • Automatically update next steps during select

Ticket

https://community.openproject.org/projects/openproject/work_packages/60154/

Screenshots

TODO

What approach did you choose and why?

Some usages of Turbo Streams were replaced with updates to a parent Turbo Frame instead, which also allows to change larger parts of the UI with simpler code (e.g. we don't need update.turbo_stream.erb anymore).

TODO: What else? Introducing current_steps, making form state management more explicit...

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Done:
* Authentication method
* Nextcloud Audience
* Properly choose second step during create

TODO:
* Properly choose step after NC audience
* Automatically update next steps during select
@NobodysNightmare NobodysNightmare marked this pull request as draft January 23, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant