[#60144] primerize wp types settings form #17704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://community.openproject.org/work_packages/60144 - remove old form for new and edit - add primer form component
NobodysNightmare
approved these changes
Jan 27, 2025
mereghost
approved these changes
Jan 27, 2025
- fetch correct parameter for copy workflow value on form submission - initialize form with this parameter if available - fix feature spec with new UI
Kharonus
force-pushed
the
implementation/60144-primerize-work-package-type-settings-form
branch
from
979dc2a to
af0a31d
Compare
NobodysNightmare
requested changes
Jan 27, 2025
mereghost
approved these changes
Jan 27, 2025
| CreateTypeService | ||
| .new(current_user) | ||
| .call(permitted_type_params, copy_workflow_from: params[:copy_workflow_from]) do |call| | ||
| .call(permitted_type_params, copy_workflow_from: params.dig(:type, :copy_workflow_from)) do |call| |
There was a problem hiding this comment.
🟡 Am I missing something here (most probably yes) but since we are feeding the all the permitted type params, why do we need to the copy_workflow_from as a special ❄️?
There was a problem hiding this comment.
copy_workflow_from is no property from the type record.
previously (as you can see from the change) it was passed not even inside params|type but directly on top level params.
Usually, having something like this, I'd rework the whole form to use a form model, as this is apparently what the create service wants. But for sake of simplicity I tried to keep the previous approach alive. But with the primer forms I no longer was able to define the form input field outside the "model".
- use maybe to convert from parameter value to integer - split create and update form options - add 303 status to redirection in types controller
NobodysNightmare
approved these changes
Jan 29, 2025
Kharonus
deleted the
implementation/60144-primerize-work-package-type-settings-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
OP#60144
What are you trying to accomplish?
What approach did you choose and why?