bug/60719 disable wp comment submitter while the form request is in progress #17696
+24
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabiru
force-pushed
the
bug/60719-duplicate-work-package-comments-when-clicking-submit-multiple-times
branch
2 times, most recently
from
dad760a to
edfe7ec
Compare
…rogress https://community.openproject.org/work_packages/60719 Prevent possible repeate submissions that can arise from slow network connections, and the user double clicking the comment submit button
akabiru
force-pushed
the
bug/60719-duplicate-work-package-comments-when-clicking-submit-multiple-times
branch
from
edfe7ec to
221c664
Compare
brunopagno
approved these changes
Jan 23, 2025
| }); | ||
| } | ||
|
|
||
| private set formSubmitInProgress(inProgress:boolean) { |
There was a problem hiding this comment.
🟢 I think semantically it would make more sense to me if we used a regular function instead of a setter here. The reason being that it's not obvious that when we do the formSubmitInProgress = value that something else is happening. It looks like a flag.
No biggie though, feel free to ignore.
There was a problem hiding this comment.
Ah, makes sense to me! Updating...
akabiru
deleted the
bug/60719-duplicate-work-package-comments-when-clicking-submit-multiple-times
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/60719
What are you trying to accomplish?
Prevent possible repeat submissions that can arise from slow network connections, and the user double clicking the comment submit button
Screenshots
*Clicking the submit button twice (quickly)
Before
double-send-slow-network.mp4
After
disable-submit-button.mp4
What approach did you choose and why?
Add submit button targets via StimulusJS to manually enable and disable the submit button onSubmit.
Turbo does automate this when using vanilla forms natively, but since we bypass the submit request to a turbo stream- it does not apply.
Merge checklist
Added/updated testsI'm not sure the tests are easy to automate here