Bug/60718 activity field populates automatically #17675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-op
requested changes
Jan 21, 2025
There was a problem hiding this comment.
@klaustopher The activity is no longer set by default.
It seems that TimeEntry.activity was automatically set/mandatory before, as there are a few places without a check.
E.g.:
The failing spec is one of them.
klaustopher
force-pushed
the
bug/60718-activity-field-populates-automatically
branch
from
80732d0 to
e9459cf
Compare
|
Tests are green |
as-op
approved these changes
Jan 21, 2025
|
Approved. So I assume the specs without checks make sure themselves the activity is set. |
klaustopher
deleted the
bug/60718-activity-field-populates-automatically
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/stream-time-and-costs/work_packages/60718
What are you trying to accomplish?
The
SetAttributeServiceused to set a default activity. As we do not consistently use that and a default feels odd according to UX, we should remove it in that place as wellMerge checklist