Bump Primer to 0.52.2 version #17667
Merged
+29
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myabc
reviewed
Jan 20, 2025
| caption: I18n.t("text_in_hours"), | ||
| trailing_visual: { text: { text: I18n.t("text_hours") } }, |
There was a problem hiding this comment.
Hi @bsatarnejad! There is already a translation in core that we can use here, I think: datetime.units.hour:
units:
hour:
one: "hour"
other: "hours"So you should be able to call I18n.t("datetime.units.hour", count: 2) or I18n.t("datetime.units.hour.other") (I'm not sure which is the more correct use of the I18n API though)
There was a problem hiding this comment.
Hi @myabc
Thanks for the hint 👍
We may use units more in the future, so it would be better to define them generally in one place, not for a specific case.
HDinger
requested changes
Jan 21, 2025
| @@ -64,7 +64,7 @@ class Meeting::TimeGroup < ApplicationForm | |||
| label: Meeting.human_attribute_name(:duration), | |||
| visually_hide_label: false, | |||
| required: true, | |||
| caption: I18n.t("text_in_hours"), | |||
| trailing_visual: { text: { text: I18n.t("datetime.units.hour.other") } }, | |||
There was a problem hiding this comment.
I see two issues here:
- The unit is shown twice (one time after the value, and one time at the end of the field)
- The unit at the end is truncated.
So I'd suggest, to get rid of the unit after the value, and at the end use an abbreviated form like "h". We may have to ask product about that however
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/59860
What are you trying to accomplish?
Bump Primer to 0.52.2 version
Use trailing units in WP create relation modal and meeting add and edit form.