[#60518] validate enterprise action in backend #17644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kharonus
force-pushed
the
implementation/60518-validate-enterprise-token-on-backend-side
branch
from
99fb480 to
f3f2206
Compare
NobodysNightmare
requested changes
Jan 20, 2025
There was a problem hiding this comment.
I'd have expected to find this validation logic on a contract, though I also find it acceptable on the update service. Just a surprise for me. Is this because updating types is different or would you also have implemented it like this on a model that follows all our usual patterns? (create service, update service, contracts, etc)
🟡 Should we have specs for the new validation?
|
Added some unit tests |
- https://community.openproject.org/work_packages/60518 - if UI is tricked, the update is guarded by an enterprise action, prevent persistence - added unit tests for pattern validation
Kharonus
force-pushed
the
implementation/60518-validate-enterprise-token-on-backend-side
branch
from
f96e564 to
71f99d2
Compare
NobodysNightmare
approved these changes
Jan 21, 2025
Kharonus
deleted the
implementation/60518-validate-enterprise-token-on-backend-side
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
OP#60519
What are you trying to accomplish?
What approach did you choose and why?