Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#60578] Unable to use the date picker for stages #17612

Merged

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Jan 15, 2025

Ticket

https://community.openproject.org/work_packages/60578

What are you trying to accomplish?

Fix the date range picker's validation preview logic on the Stages and Gates dialog. Due to a bug, the preview was triggered too early, before selecting both start and end dates. This led to an inconsistent behaviour of clearing out the input value and the selected date preventing the form to be usable.

What approach did you choose and why?

Instead of relying on the datepicker's element visiblity rely on the active class of the input field to decide whether a form preview update is required. The active class is automatically added and removed from the datepicker input, when the datepicker is open, and it's a good cue to rely on.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@dombesz dombesz changed the base branch from dev to release/12.5 January 15, 2025 11:12
@dombesz dombesz changed the base branch from release/12.5 to release/15.2 January 15, 2025 11:12
@dombesz dombesz force-pushed the bug/60578-unable-to-use-the-date-picker-for-stages branch 2 times, most recently from 99bfc5c to 818bc01 Compare January 15, 2025 11:35
@dombesz dombesz marked this pull request as ready for review January 15, 2025 11:35
Copy link

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

@dombesz dombesz force-pushed the bug/60578-unable-to-use-the-date-picker-for-stages branch from 818bc01 to 31e8ecc Compare January 15, 2025 11:40
@EinLama EinLama self-requested a review January 15, 2025 12:01
@EinLama EinLama merged commit 8a989da into release/15.2 Jan 15, 2025
13 checks passed
@EinLama EinLama deleted the bug/60578-unable-to-use-the-date-picker-for-stages branch January 15, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants