[#60578] Unable to use the date picker for stages #17612
Merged
+7
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/60578
What are you trying to accomplish?
Fix the date range picker's validation preview logic on the Stages and Gates dialog. Due to a bug, the preview was triggered too early, before selecting both start and end dates. This led to an inconsistent behaviour of clearing out the input value and the selected date preventing the form to be usable.
What approach did you choose and why?
Instead of relying on the datepicker's element visiblity rely on the
active
class of the input field to decide whether a form preview update is required. Theactive
class is automatically added and removed from the datepicker input, when the datepicker is open, and it's a good cue to rely on.Merge checklist