Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/57550 custom field with format version are ordered as strings 3 #17069

Conversation

toy
Copy link
Contributor

@toy toy commented Oct 28, 2024

Ticket

OP#57550

What are you trying to accomplish?

Followup for #16776 and #17005, this handles cleanup of Queries::Versions::Orders::NameOrder and Queries::Versions::Orders::SemverNameOrder, and remove special null handling for version, start date and due date columns.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy toy force-pushed the bug/57550-custom-field-with-format-version-are-ordered-as-strings-3 branch from a4f3d0a to a918e5b Compare October 29, 2024 18:20
@toy toy marked this pull request as ready for review October 29, 2024 18:32
@toy toy requested a review from ulferts October 29, 2024 18:32
Copy link
Contributor

@bsatarnejad bsatarnejad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@toy toy changed the base branch from dev to release/15.0 November 5, 2024 14:56
@toy toy force-pushed the bug/57550-custom-field-with-format-version-are-ordered-as-strings-3 branch from a918e5b to 757662c Compare November 5, 2024 14:57
@toy toy force-pushed the bug/57550-custom-field-with-format-version-are-ordered-as-strings-3 branch from 757662c to 8b88640 Compare November 5, 2024 19:37
@ulferts ulferts merged commit a1865c7 into release/15.0 Nov 7, 2024
13 checks passed
@ulferts ulferts deleted the bug/57550-custom-field-with-format-version-are-ordered-as-strings-3 branch November 7, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants