[57153] Reduce amount of design variables needed for the sidebar #16691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsatarnejad
force-pushed
the
57153-reduce-amount-of-design-variables-needed-for-the-sidebar
branch
from
c7c2226
to
75549a4
Compare
|
The provided work package version does not match the core version:
Please make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/57153/activity
What are you trying to accomplish?
Reduce the variables that we use for side menu colors.
Screenshots
Before:
After:
What approach did you choose and why?
We remove font and border color variables, and calculate their values based on the brightness of the respective background to ensure a high-enough contrast.
Merge checklist