use existing helpers when available

opf · Oct 23, 2024 · bc2f0d0 · bc2f0d0
1 parent 1bd1ae2
commit bc2f0d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/spec/features/work_packages/edit_work_package_spec.rb b/spec/features/work_packages/edit_work_package_spec.rb
@@ -267,7 +267,9 @@ def visit!
   context "when using the user auto completer" do
     RSpec.shared_examples "without permission" do |field_name|
       it "does not show you the email of other users" do
-        wp_page.open_user_auto_completer(field_name)
+        completer = wp_page.edit_field field_name
+        completer.activate!
+
         options = wp_page.visible_user_auto_completer_options
 
         expected_options = [
@@ -281,7 +283,9 @@ def visit!
 
     RSpec.shared_examples "with permission" do |field_name|
       it "does show you the email of other users" do
-        wp_page.open_user_auto_completer(field_name)
+        completer = wp_page.edit_field field_name
+        completer.activate!
+
         options = wp_page.visible_user_auto_completer_options
 
         expected_options = [

diff --git a/spec/support/pages/work_packages/abstract_work_package.rb b/spec/support/pages/work_packages/abstract_work_package.rb
@@ -330,10 +330,6 @@ def mark_notifications_as_read
       find('[data-test-selector="mark-notification-read-button"]').click
     end
 
-    def open_user_auto_completer(field = "assignee")
-      find("op-editable-attribute-field[ng-reflect-field-name='#{field}'] [role='button']", wait: 10).click
-    end
-
     # Finds the currently visible, expanded user auto completer and returns its dropdown menu options.
     # A user always has a name, but their email is only visible in certain circumstances, so that value
     # might be nil.