treat number strings ending with . uniformely in the DurationConverter

opf · Jan 23, 2025 · 005e391 · 005e391
1 parent 0155c22
commit 005e391
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/app/services/duration_converter.rb b/app/services/duration_converter.rb
@@ -111,7 +111,9 @@ def output(duration_in_hours, format: default_format)
 
     def parseable?(duration_string)
       if number = Integer(duration_string, 10, exception: false) || Float(duration_string, exception: false)
-        number >= 0
+        # ruby 3.4 started being able to parse strings like "1." as 1.0.
+        # However, that does not work with ChronicDuration.
+        number >= 0 && !duration_string.ends_with?(".")
       else
         begin
           do_parse(duration_string)