This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Makefile: various fixes #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joelanford
commented
May 15, 2024
•
joelanford
commented
- explicitly configure shell
- change CONTAINER_RUNTIME error to warning
- fix broken GORELEASER_ARGS setup
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
- explicitly configure shell - change CONTAINER_RUNTIME error to warning - fix broken GORELEASER_ARGS setup
joelanford
force-pushed
the
makefile-fixes
branch
from
654ba54
to
6a27013
Compare
joelanford
changed the title
|
I think I found the issue with the 1.21 release GHA. I messed up the GORELEASER_ARGS variable setup in a previous PR. I think this is likely to fix the issue |
openshift-ci
bot
removed
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 37.95% 37.95%
=======================================
Files 9 9
Lines 843 843
=======================================
Hits 320 320
Misses 481 481
Partials 42 42 ☔ View full report in Codecov by Sentry. |
grokspawn
approved these changes
May 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.