-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
WithVolumeMounts(func() []*applyconfigurationcorev1.VolumeMountApplyConfiguration { | ||
var volumeMounts []*applyconfigurationcorev1.VolumeMountApplyConfiguration | ||
if gocoverdirEnv != "" { | ||
volumeMounts = append(volumeMounts, applyconfigurationcorev1.VolumeMount(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A temporary fix to get e2e's running in operator controller!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 37.27% 37.27%
=======================================
Files 9 9
Lines 845 845
=======================================
Hits 315 315
Misses 486 486
Partials 44 44 ☔ View full report in Codecov by Sentry. |
WithMountPath("/bin")) | ||
return volumeMounts | ||
}()...). | ||
WithEnv(applyconfigurationcorev1.EnvVar().WithName("GOCOVERDIR").WithValue(gocoverdirEnv)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we only set this if gocoverdirEnv != ""
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing an empty configuration is causing errors. Tried various options, but looks like the only one is to create the entire container spec separately based on whether env var is present or not.
Leaving it to be as is for now, if the env is not set it results in an empty string which doesn't cause a problem for now. Also this is just a band aid, and will replaced by direct registry client anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR adds the go test coverage variable to the unpack pod. It also creates necessary volumes if the GOCOVERDIR env var is set. Signed-off-by: Varsha Prasad Narsing <[email protected]>
35b95ac
/lgtm |
This PR adds the go test coverage variable to the
unpack pod. It also creates necessary volumes
if the GOCOVERDIR env var is set.