-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
pkg/convert/registryv1.go
Outdated
// Add the install namespace | ||
ns := &corev1.Namespace{ | ||
TypeMeta: metav1.TypeMeta{Kind: "Namespace", APIVersion: "v1"}, | ||
ObjectMeta: metav1.ObjectMeta{Name: installNamespace}, | ||
} | ||
objs = append(objs, ns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed this in the InstallNamespace
PR. The expectation is that the install namespace will already exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that wasn't true in our PoC, but it means we'll have to deal with it better during test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't. This change just merged yesterday in rukpak and today in operator-controller. If you're able to rebase to operator-controller main
, you shouldn't need this.
In anticipation of using rukpak as a library, export some of the functionality. This primarilly meant moving files from `internal` to `pkg`. Signed-off-by: Todd Short <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
=======================================
Coverage 37.27% 37.27%
=======================================
Files 9 9
Lines 845 845
=======================================
Hits 315 315
Misses 486 486
Partials 44 44 ☔ View full report in Codecov by Sentry. |
I don't love all of this being moved out from |
In anticipation of using rukpak as a library, export some of the functionality. This primarilly meant moving files from
internal
topkg
.