This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
deps: align ginkgo CLI to lib, use available helm-operator-plugins API improvements #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 36.63% 37.28% +0.64%
==========================================
Files 9 9
Lines 868 853 -15
==========================================
Hits 318 318
+ Misses 506 491 -15
Partials 44 44 ☔ View full report in Codecov by Sentry. |
…I improvements Signed-off-by: Joe Lanford <[email protected]>
perdasilva
reviewed
Apr 10, 2024
| @@ -29,11 +29,11 @@ $(CONTROLLER_GEN): $(BINGO_DIR)/controller-gen.mod | |||
| @echo "(re)installing $(GOBIN)/controller-gen-v0.14.0" | |||
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=controller-gen.mod -o=$(GOBIN)/controller-gen-v0.14.0 "sigs.k8s.io/controller-tools/cmd/controller-gen" | |||
|
|
|||
| GINKGO := $(GOBIN)/ginkgo-v2.15.0 | |||
| GINKGO := $(GOBIN)/ginkgo-v2.17.1 | |||
There was a problem hiding this comment.
non-blocking, but would it be worth it to put the ginkgo version in a variable?
There was a problem hiding this comment.
@perdasilva This is an auto generated file by the bingo tool
Merged
via the queue into
operator-framework:main
with commit Apr 10, 2024
c28caf5
9 of 10 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #534