This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
✨ Support for other Install strategies #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
==========================================
+ Coverage 26.29% 35.27% +8.97%
==========================================
Files 9 9
Lines 810 808 -2
==========================================
+ Hits 213 285 +72
+ Misses 551 479 -72
+ Partials 46 44 -2 ☔ View full report in Codecov by Sentry. |
varshaprasad96
force-pushed
the
support-watchnamespaces
branch
from
1790528 to
1939808
Compare
Which deployment are you referring to, could you elaborate pl? This PR introduces a spec field where watchnamespaces can specified while creating a BD (ref). It would then be added to cluster extension too. |
varshaprasad96
force-pushed
the
support-watchnamespaces
branch
from
1939808 to
f68ed95
Compare
varshaprasad96
changed the title
ncdc
reviewed
Jan 19, 2024
This PR removes the requirement that AllNamespace mode should be supported always in a registry+v1 format. It does so by: 1. Adding a field to specify watch namespaces in BundleDeployment Spec. 2. While converting from registryV1 to plain bundle, we now generate roles for all specified targetNamespaces which are being watched. Signed-off-by: Varsha Prasad Narsing <[email protected]>
varshaprasad96
force-pushed
the
support-watchnamespaces
branch
from
f68ed95 to
c4a3a1b
Compare
everettraven
approved these changes
Jan 19, 2024
joelanford
reviewed
Jan 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #772
This PR removes the requirement that AllNamespace mode should be supported always in a registry+v1 format.
It does so by: