This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Add initial Tilt support #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 31.94% 31.94%
=======================================
Files 10 10
Lines 479 479
=======================================
Hits 153 153
Misses 304 304
Partials 22 22 |
everettraven
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Thanks @ncdc - this is super neat! I'm happy for this to go in as is and iterate to make improvements to the Tiltfile and the use of tilt as we go
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Switched to draft mode for a bit. I forgot to add docs about a cert-manager requirement. Working on that. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Added |
tmshort
reviewed
Jul 25, 2023
|
Thanks, updated |
Signed-off-by: Andy Goldstein <[email protected]>
tmshort
suggested changes
Jul 25, 2023
|
No, because the context used to build the images is bin/linux |
tmshort
approved these changes
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs (either for this PR or as follow-ups)