-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
Codecov Report
@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 31.94% 31.94%
=======================================
Files 10 10
Lines 479 479
=======================================
Hits 153 153
Misses 304 304
Partials 22 22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ncdc - this is super neat! I'm happy for this to go in as is and iterate to make improvements to the Tiltfile and the use of tilt as we go
Switched to draft mode for a bit. I forgot to add docs about a cert-manager requirement. Working on that. |
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have similar comments to those I made in operator-controller
Thanks, updated |
Signed-off-by: Andy Goldstein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need .dockerignore
?
No, because the context used to build the images is bin/linux |
TODOs (either for this PR or as follow-ups)