Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Commit

Permalink
Improve error message for all namespaces
Browse files Browse the repository at this point in the history
Signed-off-by: Mikalai Radchuk <[email protected]>
  • Loading branch information
m1kola committed Jun 12, 2024
1 parent 2cb02e5 commit b5e3428
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/convert/registryv1.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ func validateTargetNamespaces(supportedInstallModes sets.Set[string], installNam
if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeAllNamespaces)) {
return nil
}
return fmt.Errorf("supported install modes %v do not support targeting all namespaces", sets.List(supportedInstallModes))
case set.Len() == 1 && !set.Has(""):
if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeSingleNamespace)) {
return nil
Expand Down

0 comments on commit b5e3428

Please sign in to comment.