This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This PR fixes an issue where helm's postrenderer used to override the user defined object labels instead of merging them. Signed-off-by: Varsha Prasad Narsing <[email protected]>
- Loading branch information
1 parent
802fe8a
commit 7802031
Showing
2 changed files
with
97 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
internal/controllers/bundledeployment/bundledeployment_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
package bundledeployment | ||
|
||
import ( | ||
"bytes" | ||
"encoding/json" | ||
"testing" | ||
|
||
. "github.com/onsi/ginkgo/v2" | ||
. "github.com/onsi/gomega" | ||
"helm.sh/helm/v3/pkg/postrender" | ||
corev1 "k8s.io/api/core/v1" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"k8s.io/apimachinery/pkg/runtime/schema" | ||
|
||
rukpakv1alpha1 "github.com/operator-framework/rukpak/api/v1alpha1" | ||
"github.com/operator-framework/rukpak/internal/util" | ||
) | ||
|
||
func TestBundleDeploymentController(t *testing.T) { | ||
RegisterFailHandler(Fail) | ||
RunSpecs(t, "BundleDeployment Controller Suite") | ||
} | ||
|
||
var _ = Describe("BundleDeployment", func() { | ||
var _ = Describe("PostRenderer", func() { | ||
var ( | ||
postren postrender.PostRenderer | ||
pod corev1.Pod | ||
inBuf bytes.Buffer | ||
) | ||
|
||
BeforeEach(func() { | ||
postren = &postrenderer{ | ||
labels: map[string]string{ | ||
util.CoreOwnerKindKey: rukpakv1alpha1.BundleDeploymentKind, | ||
util.CoreOwnerNameKey: "test-owner", | ||
}, | ||
} | ||
|
||
pod = corev1.Pod{ | ||
ObjectMeta: metav1.ObjectMeta{ | ||
Name: "testPod", | ||
Labels: map[string]string{ | ||
"testKey": "testValue", | ||
}, | ||
}, | ||
} | ||
pod.SetGroupVersionKind(schema.GroupVersionKind{Group: "", Version: "v1", Kind: "Pod"}) | ||
|
||
}) | ||
|
||
It("should preserve existing labels present in the pod", func() { | ||
By("encoding pod") | ||
Expect(json.NewEncoder(&inBuf).Encode(pod)).NotTo(HaveOccurred()) | ||
|
||
By("verifying if postrender ran successfully") | ||
outBuf, err := postren.Run(&inBuf) | ||
Expect(err).NotTo(HaveOccurred()) | ||
Expect(outBuf.String()).NotTo(BeEmpty()) | ||
|
||
By("converting output string back to pod") | ||
renderedPod := &corev1.Pod{} | ||
Expect(json.Unmarshal(outBuf.Bytes(), renderedPod)).NotTo(HaveOccurred()) | ||
Expect(renderedPod).NotTo(BeNil()) | ||
|
||
labels := renderedPod.GetLabels() | ||
Expect(len(labels)).To(BeEquivalentTo(3)) | ||
Expect(labels).Should(HaveKeyWithValue("testKey", "testValue")) | ||
Expect(labels).Should(HaveKeyWithValue("core.rukpak.io/owner-kind", "BundleDeployment")) | ||
Expect(labels).Should(HaveKeyWithValue("core.rukpak.io/owner-name", "test-owner")) | ||
}) | ||
|
||
It("should add default labels to the pod", func() { | ||
pod.SetLabels(map[string]string{}) | ||
|
||
By("encoding pod") | ||
Expect(json.NewEncoder(&inBuf).Encode(pod)).NotTo(HaveOccurred()) | ||
|
||
By("verifying if postrender ran successfully") | ||
outBuf, err := postren.Run(&inBuf) | ||
Expect(err).NotTo(HaveOccurred()) | ||
Expect(outBuf.String()).NotTo(BeEmpty()) | ||
|
||
By("converting output string back to pod") | ||
renderedPod := &corev1.Pod{} | ||
Expect(json.Unmarshal(outBuf.Bytes(), renderedPod)).NotTo(HaveOccurred()) | ||
Expect(renderedPod).NotTo(BeNil()) | ||
|
||
labels := renderedPod.GetLabels() | ||
Expect(len(labels)).To(BeEquivalentTo(2)) | ||
Expect(labels).Should(HaveKeyWithValue("core.rukpak.io/owner-kind", "BundleDeployment")) | ||
Expect(labels).Should(HaveKeyWithValue("core.rukpak.io/owner-name", "test-owner")) | ||
}) | ||
|
||
}) | ||
}) |