This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
WIP [v1alpha2]: refactor controller #1975
varshaprasad96Annotations
11 errors and 7 warnings
|
verify
Process completed with exit code 2.
|
|
lint:
internal/controllers/v1alpha2/controllers/util/util.go#L8
File is not `goimports`-ed with -local github.com/operator-framework/rukpak (goimports)
|
|
lint:
internal/controllers/v1alpha2/source/git.go#L23
File is not `goimports`-ed with -local github.com/operator-framework/rukpak (goimports)
|
|
lint:
internal/controllers/v1alpha2/source/image.go#L20
File is not `goimports`-ed with -local github.com/operator-framework/rukpak (goimports)
|
|
lint:
internal/controllers/v1alpha2/source/git.go#L123
G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
|
|
lint:
internal/controllers/v1alpha2/controllers/bundledeployment/bundledeployment.go#L151
`unkown` is a misspelling of `unknown` (misspell)
|
|
lint:
internal/controllers/v1alpha2/controllers/bundledeployment/bundledeployment.go#L154
`availabe` is a misspelling of `available` (misspell)
|
|
lint:
internal/controllers/v1alpha2/controllers/bundledeployment/bundledeployment.go#L183
`unkown` is a misspelling of `unknown` (misspell)
|
|
lint:
internal/controllers/v1alpha2/controllers/bundledeployment/bundledeployment.go#L134
(*bundleDeploymentReconciler).reconcile - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
|
|
lint:
internal/controllers/v1alpha2/source/git.go#L122
func `createFile` is unused (unused)
|
|
lint:
internal/controllers/v1alpha2/source/image.go#L241
func `(*Image).getBundleContents` is unused (unused)
|
|
lint:
internal/provisioner/registry/registry.go#L15
unused-parameter: parameter 'fsys' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/controllers/v1alpha2/source/image.go#L71
unused-parameter: parameter 'base' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/controllers/v1alpha2/source/image.go#L156
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/controllers/v1alpha2/validator/validator.go#L42
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/controllers/v1alpha2/validator/validator.go#L53
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/controllers/v1alpha2/deployer/deploy.go#L252
receiver-naming: receiver name bd should be consistent with previous receiver name hd for helmDeployer (revive)
|
|
lint:
internal/controllers/v1alpha2/deployer/deploy.go#L81
exported: type name will be used as deployer.DeployerOption by other packages, and that stutters; consider calling this Option (revive)
|