Update api dependency to 0.19.0

[kevinrizza]

Bump api dependency.

Since that api change is related to validation types, rather than ingest the validation data this change does the first step of #1158 and marks opm alpha bundle validate as deprecated.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b137480) 53.81% compared to head (61f507a) 53.81%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1157   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files         108      108           
  Lines       10224    10224           
=======================================
  Hits         5502     5502           
+ Misses       3749     3748    -1     
- Partials      973      974    +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joelanford]

Are we also going to add the new validators for opm alpha bundle validate?

• standardcategories
• standardcapabilities
• operatorhubv2

Also, is there a reason that both operator-sdk and opm have entrypoints to run the api-provided validators? Also, why is opm's set of available validators much smaller that SDK's?

[joelanford]

To me, it kinda seems like we should remove opm alpha bundle validate entirely and point everyone to the SDK validation.

[kevinrizza]

@joelanford totally agree, I actually took a quick look at the validation bits and decided against changing anything there because it just doesn't seem valuable. I'm bumping this dependency not to update anything there but just because it's got a transitive dependency to the api that needs to be updated before the sdk can consume the latest version.

If you want, I can just get rid of the alpha bundle validate command as part of this pull request

[joelanford]

I don't know if anyone is using the opm alpha bundle validate command, so I'm hesitant to just drop it out of nowhere (and yeah, I realize it's alpha, so we have every right to). I'll make an issue to capture our desire to remove it.

Maybe for now, we update that command to output a clear deprecation message? Something along the lines of "this subcommand is deprecated and will be removed. Migrate to operator-sdk bundle validate"?

[joelanford]

#1158

[kevinrizza]

@joelanford makes sense to me. I added a deprecation warning to the command.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, kevinrizza, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [joelanford,kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joelanford]

/lgtm