-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-introduce and fix declcfg.Meta unmarshal error #1109
re-introduce and fix declcfg.Meta unmarshal error #1109
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
+ Coverage 52.35% 52.63% +0.27%
==========================================
Files 107 108 +1
Lines 9688 9703 +15
==========================================
+ Hits 5072 5107 +35
+ Misses 3674 3654 -20
Partials 942 942
|
/hold |
Signed-off-by: Joe Lanford <[email protected]>
113199f
to
b991fa8
Compare
/hold cancel Beefed up the logic, added unit tests to prove things work and to prevent regressions. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description of the change:
Re-introduce pretty-printing of json.Unmarshal errors encountered with unmarshaling
declcfg.Meta
objects.Motivation for the change:
Prior to #1094, we had some nice pretty printing of JSON unmarshaling errors. That pretty printing also had a bug that caused an index out-of-bounds panic.
In #1094, we inadvertently stopped using the pretty-printing. This technically solved the panic bug, but we lost the pretty-printing as well.
Reviewer Checklist
/docs