Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add protocols to all ports in olm.yaml quickstart #3421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lgo
Copy link

@lgo lgo commented Oct 26, 2024

Description of the change:

Adds protocol to all of the ports defined in the `olm.yaml quickstart.

Motivation for the change:

I was setting up OLM with kustomization and ArgoCD, and the ArgoCD was unable to diff or sync due to the lack of protocol on the apiVersion=operators.coreos.com/v1alpha1 verison=ClusterServiceVersion resource. I figured I'd add the protocol to the two Deployment while I'm here anyways.


ComparisonError: Failed to compare desired state to live state: failed to calculate diff: error calculating structured merge diff: error building typed value from config resource: .spec.install.spec.deployments[0].spec.template.spec.containers[0].ports: element 0: associative list with keys has an element that omits key field "protocol" (and doesn't have default value). Retrying attempt #4 at 11:59AM.

As I understand, this is because the CRD doesn't have a default, which is probably another thing that's worth fixing.

Architectural changes:

N/A

Testing remarks:

  • I used my forked version and it worked fine with ArgoCD afterwards

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Copy link

openshift-ci bot commented Oct 26, 2024

Hi @lgo. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2024
@openshift-ci openshift-ci bot requested review from dinhxuanvu and oceanc80 October 26, 2024 23:39
@perdasilva perdasilva removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2024
@m1kola
Copy link
Member

m1kola commented Nov 4, 2024

We have broken release automation which I'm trying to fix now. Don't want to add more variables into the mix so putting this on hold for now.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
@m1kola
Copy link
Member

m1kola commented Nov 4, 2024

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants