Skip to content

✨ (pre-flight check) Improve error message #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Jun 3, 2025

Description

The line "failed to get release state using client-only dry-run" is too jargon heavy, and meaningless for the end user.
This PR replaces the error message with a more user friendly text.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120 anik120 requested a review from a team as a code owner June 3, 2025 19:56
Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1fc3d52
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/683f55ea11ef13000803073b
😎 Deploy Preview https://deploy-preview-2006--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anik120 anik120 force-pushed the improve-preflight-check-error-message branch from 6b10130 to 1513098 Compare June 3, 2025 19:58
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might broke the downstream tests :-(
Last time I think they were matching the string

@tmshort @jianzhangbjz for you be aware of the change.

But I either liked more the new message 👍

@camilamacedo86 camilamacedo86 requested a review from bentito June 3, 2025 20:00
The line "failed to get release state using client-only dry-run" is too
jargon heavy, and meaningless for the end user.
This PR replaces the error message with a more user friendly text.
@anik120 anik120 force-pushed the improve-preflight-check-error-message branch from 1513098 to 1fc3d52 Compare June 3, 2025 20:07
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.21%. Comparing base (8f81c23) to head (1fc3d52).

Files with missing lines Patch % Lines
internal/operator-controller/applier/helm.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
+ Coverage   69.17%   69.21%   +0.04%     
==========================================
  Files          79       79              
  Lines        7037     7037              
==========================================
+ Hits         4868     4871       +3     
+ Misses       1887     1885       -2     
+ Partials      282      281       -1     
Flag Coverage Δ
e2e 43.06% <0.00%> (+0.05%) ⬆️
unit 60.06% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants