Skip to content

⚠️ OPRUN-3954: Update CRD generator to support experimental CRDs #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented May 20, 2025

Fix #2014

Add support for a new CRD generator. This generator will use opcon
tags to identify experimental features. A script runs the CRD
generation, and creates all the CRDs.

New experimental CRDs are now created.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner May 20, 2025 20:44
Copy link

netlify bot commented May 20, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 67e085b
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6859e8fa5524250008e4f584
😎 Deploy Preview https://deploy-preview-1980--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort tmshort added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 75.35545% with 52 lines in your changes missing coverage. Please review.

Project coverage is 73.87%. Comparing base (d844c45) to head (67e085b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
hack/tools/crd-generator/main.go 75.35% 35 Missing and 17 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
+ Coverage   73.86%   73.87%   +0.01%     
==========================================
  Files          80       81       +1     
  Lines        7154     7365     +211     
==========================================
+ Hits         5284     5441     +157     
- Misses       1548     1584      +36     
- Partials      322      340      +18     
Flag Coverage Δ
e2e 44.10% <ø> (-0.05%) ⬇️
unit 60.66% <75.35%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort force-pushed the api-generator-test branch 4 times, most recently from a5c717d to 6a6c223 Compare May 21, 2025 18:39
@tmshort
Copy link
Contributor Author

tmshort commented Jun 5, 2025

/unhold

@tmshort tmshort force-pushed the api-generator-test branch from 6a6c223 to 778d86c Compare June 5, 2025 18:12
@tmshort tmshort changed the title ⚠️ WIP: crd-generator-work ⚠️ Update CRD generator to support experimental CRDs Jun 5, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Jun 5, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@tmshort tmshort force-pushed the api-generator-test branch from e6b2315 to 953be02 Compare June 12, 2025 18:54
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2025
@tmshort tmshort force-pushed the api-generator-test branch from 953be02 to dc3d821 Compare June 17, 2025 12:34
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
Add support for a new CRD generator. This generator will use `opcon`
tags to identify experimental features. A script runs the CRD
generation, and creates all the CRDs.

New experimental CRDs are now created.

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort force-pushed the api-generator-test branch from dc3d821 to 30aeef7 Compare June 23, 2025 18:52
@tmshort tmshort changed the title ⚠️ Update CRD generator to support experimental CRDs ⚠️ OPRUN-3954: Update CRD generator to support experimental CRDs Jun 24, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Jun 24, 2025

Yes, crd-diff is failing, because I moved the location of the CRD file.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we have the experimental fields to ensure that it works well as expected. However, I think we can change and improve in follow ups if you need to.

So, it seems good enough as first step at least

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
Copy link

openshift-ci bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor Author

tmshort commented Jun 24, 2025

It would be nice if we have the experimental fields to ensure that it works well as expected. However, I think we can change and improve in follow ups if you need to.

The unit test does try to use some experimental fields, but we don't have any in the main codebase.

@tmshort tmshort merged commit 9380928 into operator-framework:main Jun 24, 2025
21 of 23 checks passed
@tmshort tmshort deleted the api-generator-test branch June 24, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce New CRD Generation Tooling
3 participants