Skip to content

⚠️ Update CRD generator to support experimental CRDs #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

⚠️ Update CRD generator to support experimental CRDs #1980

wants to merge 3 commits into from
+1,537 −17

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented May 20, 2025 •
edited
Loading

Fix #2014

Add support for a new CRD generator. This generator will use opcon
tags to identify experimental features. A script runs the CRD
generation, and creates all the CRDs.

New experimental CRDs are now created.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner May 20, 2025 20:44
@netlify Netlify
Copy link

netlify bot commented May 20, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 953be02
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/684b2257201d3500087100e3
😎 Deploy Preview https://deploy-preview-1980--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort tmshort added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@codecov Codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.65385% with 86 lines in your changes missing coverage. Please review.

Project coverage is 68.95%. Comparing base (8f81c23) to head (778d86c).

Files with missing lines Patch % Lines
hack/tools/crd-generator/main.go 58.65% 67 Missing and 19 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
- Coverage   69.17%   68.95%   -0.22%     
==========================================
  Files          79       80       +1     
  Lines        7037     7245     +208     
==========================================
+ Hits         4868     4996     +128     
- Misses       1887     1950      +63     
- Partials      282      299      +17
Flag Coverage Δ
e2e 43.11% <ø> (+0.11%) ⬆️
unit 60.02% <58.65%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort force-pushed the api-generator-test branch 4 times, most recently from a5c717d to 6a6c223 Compare May 21, 2025 18:39
@tmshort
Copy link
Contributor Author

tmshort commented Jun 5, 2025

/unhold

@tmshort tmshort force-pushed the api-generator-test branch from 6a6c223 to 778d86c Compare June 5, 2025 18:12
@tmshort tmshort changed the title ⚠️ WIP: crd-generator-work ⚠️ Update CRD generator to support experimental CRDs Jun 5, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Jun 5, 2025

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
tmshort added 3 commits June 12, 2025 14:52
@tmshort
Update CRD generator to support experimental CRDs
bd4d727 
Add support for a new CRD generator. This generator will use `opcon`
tags to identify experimental features. A script runs the CRD
generation, and creates all the CRDs.

New experimental CRDs are now created.

Signed-off-by: Todd Short <[email protected]>
@tmshort
fixup! Update CRD generator to support experimental CRDs
c0702f5 
Signed-off-by: Todd Short <[email protected]>
@tmshort
fixup! Update CRD generator to support experimental CRDs
953be02 
Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort force-pushed the api-generator-test branch from e6b2315 to 953be02 Compare June 12, 2025 18:54
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce New CRD Generation Tooling
2 participants
@tmshort @openshift-merge-robot