Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes enableGitInfo config param #289

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Apr 13, 2023

Default value is false. This effectively disables "Last modified" at the end of the page in docs.

As per discussion here.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2023
Default value is false. This effectively disables "Last modified"
at the end of the page in docs.
@@ -1 +1,3 @@
{{ T "post_last_mod"}} {{ .Lastmod.Format .Site.Params.time_format_default }}{{ with .GitInfo }}: <a href="{{ $.Site.Params.github_repo }}/commit/{{ .Hash }}">{{ .Subject }} ({{ .AbbreviatedHash }})</a>{{end }}
{{ if and (.GitInfo) (.Site.Params.github_repo) -}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm modifying docsy theme files and we already have quite a lot of modifications in the theme (in vendored fiels basically) but it will all go away once we merge #284.

@m1kola m1kola marked this pull request as ready for review April 13, 2023 12:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2023
@m1kola m1kola requested a review from grokspawn April 13, 2023 12:43
@grokspawn grokspawn enabled auto-merge (squash) April 13, 2023 13:31
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I actually like having the "Last Modified" at the bottom because it lets me know how recent the information is. That being said, this looks good based on previous consensus that it should be removed

@grokspawn grokspawn merged commit 164fa1f into operator-framework:master Jun 13, 2023
@m1kola m1kola deleted the enableGitInfo-false branch June 13, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants