-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Hugo & removes vendored docsy #284
Changes from 1 commit
2b61bc2
f29602f
77298d6
c2ca24a
dc1edd9
b695d0b
9f50e25
554c131
6db50ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
{{ with .Site.Params.algolia_docsearch }} | ||
<script type="text/javascript" src="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.js"></script> | ||
<script type="text/javascript"> docsearch({ | ||
apiKey: 'e11ae88fced1b3f21f2c26a2ddf729d5', | ||
indexName: 'operatorframework', | ||
inputSelector: '.td-search-input', | ||
debug: false // Set debug to true if you want to inspect the dropdown | ||
}); | ||
</script> | ||
<script src="https://cdn.jsdelivr.net/npm/@docsearch/js@3"></script> | ||
<script type="text/javascript">docsearch({ | ||
container: '#docsearch', | ||
appId: 'BH4D9OD16A', | ||
apiKey: 'e11ae88fced1b3f21f2c26a2ddf729d5', | ||
indexName: 'operatorframework', | ||
});</script> | ||
{{ end }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
{{ with .Site.Params.algolia_docsearch }} | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" /> | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@docsearch/css@3" /> | ||
<style> | ||
.DocSearch-Container { | ||
z-index: calc(var(--of--header-main) + 1); | ||
} | ||
</style> | ||
Comment on lines
+3
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why change this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stuff like these definitely don't have to be in the same PR though. "Change the look and feel of the search box" is not mentioned anywhere in the PR description/commit messages and yet these changes are there included in the commits. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @anik120 PR description mentions this:
https://docsearch.algolia.com/docs/legacy/dropdown/ This specific style is required so that search popup of docsearch v3 doesn't get covered by header (it wasn't an issue in v2 due to different placement of v2 search overlay).
Because this repo is so outdated it is impossible (or at least I do not see a way) to split it into smaller changes. You change one thing - you have to change another. It is a can of worms. |
||
{{ end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a LOT of these sprinkled all over, which makes it really hard to focus on the actual changes. Lot of brain power is just needed for filtering out the noise. I'm guessing this is a text editor setting that needs to be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anik120 I agree - people who commit a bunch of spaces at the end of lines should fix their editors :)
In the meantime -
git diff upstream/master -w
(or--ignore-space-at-eol
) should help with that.Github UI also has a setting for this. I hope this helps.