Improve customizability of SSABasedGenericKubernetesResourceMacher #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murillio4
force-pushed
the
customizeable-ssabased-matcher-2553
branch
from
6d39813 to
35dc05a
Compare
…cher Signed-off-by: Mattis Bratland <[email protected]>
murillio4
force-pushed
the
customizeable-ssabased-matcher-2553
branch
from
35dc05a to
5c4fdbd
Compare
xstefank
approved these changes
Apr 8, 2025
|
We should probably make it easier to use an SSA matcher without having to override the |
csviri
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2509 and makes it easier to customize the matching logic in SSABasedGenericKubernetesResourceMatcher without having to clone the entire class just to override its behavior.
The change is based on the solution suggested by @Donnerbart here, but it avoids passing the primary resource directly in order to keep the existing matches method signature unchanged. If the primary resource is needed, it can instead be made available through the context.
The implementation introduces a new protected matches method that handles the actual comparison. The public matches method delegates to this new method, making it easy to override in subclasses.