Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: mapping from annotation depends on type #2599

Closed
wants to merge 96 commits into from
Closed

improve: mapping from annotation depends on type #2599

wants to merge 96 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Nov 20, 2024

compiles

csviri and others added 30 commits November 19, 2024 18:24
@csviri @metacosm
chore: set version to 5.0.0-SNAPSHOT (#2200)
af984eb 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: java version minimal 11, tested on 21 (#2207)
5cbf27e 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove deprecated EventFilter (#2208)
0ec15cc 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
docs: 5.0 migration guide skeleton (#2210)
3ec4c74 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: managed dependent reconciliation results not optional (#2212)
bd01373 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove deprecated RetryConfiguration (#2211)
08722ed 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: JDK client is now the default (#2235)
098b09a 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
fix: update SCM information (#2237)
a9aa902 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: move name is directly to dependent resource (#2250)
9f4a8fe 
* feat: move name is directly to dependent resource

- use this name when throwing aggregate exception

Signed-off-by: Attila Mészáros <[email protected]>

* refactor to use a dedicated interface for setting the name

Signed-off-by: Attila Mészáros <[email protected]>

* refactor: add default implementation for name() (#2255)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
format
2774337 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: test after rebase on master (#2270)
6148054 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: use java 17 as baseline (#2271)
baa5375 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: matcher always considers metadata (#2273)
b14a9a9 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: API to check if next reconciliation is imminent (#2272)
67be083 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
839ee11 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: pom properties cleanup (#2280)
2fd36b9 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove EventSourceInitializer (#2257)
8b4c691 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: make loadFromProperties private (#2287)
39425bb 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
082de83 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: explicit workflow invocation (#2289)
3670e99 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
0c7bef5 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: make WorkflowSpec an interface (#2300)
f84a310 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: replace current formatting plugins with spotless plugin (#2302)
8a96120 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: make ManagedWorkflowSupport public to be able to reuse it (#…
a2b4b0b 
…2308)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: package fix leader election sample (#2303)
93c1b58 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: remove resource discriminator (#2299)
2356afe 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: remove deprecated getTerminationTimeoutSeconds and associat…
e31de33 
…ed (#2297)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: additional logging to mysql schema e2e test (#2320)
f695ba3 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
3041593 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: using SSA for finalizer and primary patch (#2305)
76c52d7 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
10000-ki and others added 16 commits November 19, 2024 21:24
@10000-ki @metacosm
feat: print diff resource as yaml (#2542)
780c70f
@csviri @metacosm
fix: integration test timeout issue (#2547)
b77086a 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: naming target resource selector method (#2546)
c790130
@bachmanity1 @metacosm
feat: improve diff logging (#2544)
cf5e2e3 
* imporve diff logging

Signed-off-by: bachmanity1 <[email protected]>

* compute diff only when actual doesn't match desired

Signed-off-by: bachmanity1 <[email protected]>

* slight improvements

Signed-off-by: bachmanity1 <[email protected]>

* increase context size

Signed-off-by: bachmanity1 <[email protected]>

* fix style

Signed-off-by: bachmanity1 <[email protected]>

* calculate diff only if debug is enabled

Signed-off-by: bachmanity1 <[email protected]>

* print actual resources when trace is enabled

Signed-off-by: bachmanity1 <[email protected]>

* use java-diff-utils

Signed-off-by: bachmanity1 <[email protected]>

* add unit tests

---------

Signed-off-by: bachmanity1 <[email protected]>
@metacosm
fix: race condition in workflow reconciler (#2549)
4579beb 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
feat(ci): split integration tests execution by category (#2548)
66fdaf1 
* feat(build): split ITs by category, parallel CRD generation

Also avoid generating CRDs when not needed by default, summarizes test
results.

* chore(deps): bump actions-setup-minikube to 2.13.0
* feat: default to use vertx client
* chore(ci): reduce tested combinations, only run client tests on baseapi
* fix: increase deletion timeout

---------

Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: rename method more appropriately (#2554)
cf97244 
Signed-off-by: Chris Laprun <[email protected]>
@csviri @metacosm
improve: workflow builder naming (#2559)
836d738
@metacosm
chore: adapt after rebase
772f358 
Signed-off-by: Chris Laprun <[email protected]>
@Donnerbart @metacosm
fix: infinite resource updates due to canonical format conversion of …
4187a4a 
…resource requirements (#2565)

* refactor: clean up SSABasedGenericKubernetesResourceMatcher

Signed-off-by: David Sondermann <[email protected]>

* test: add missing tests for StatefulSet with VolumeClaimTemplates for SSABasedGenericKubernetesResourceMatcher

Signed-off-by: David Sondermann <[email protected]>

* fix: Fix infinite resource updates due to canonical format conversion of resource requirements

Signed-off-by: David Sondermann <[email protected]>

* test: Add test cases with init containers to ResourceRequirementsSanitizerTest

Signed-off-by: David Sondermann <[email protected]>

---------

Signed-off-by: David Sondermann <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
@csviri @metacosm
fix: concurrent modification when getting event sources (v5) (#2572)
8c5dfd3
@csviri @metacosm
fix: issue after rebase
8c6dccc 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: formatting issue after rebase (#2582)
66d0f16
@csviri @metacosm
fix: docs double header in migration docs (#2584)
3386c95
@metacosm
refactor: minor (#2594)
a0bafc2 
Signed-off-by: Chris Laprun <[email protected]>
@csviri
improve: mapping from annotation depends on type
481d38b 
Signed-off-by: Attila Mészáros <[email protected]>

compiles

Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri requested a review from metacosm November 20, 2024 12:52
@openshift-ci openshift-ci bot requested a review from adam-sandor November 20, 2024 12:52
@csviri csviri requested review from xstefank and removed request for adam-sandor November 20, 2024 12:52
@csviri csviri mentioned this pull request Nov 20, 2024
Closed
@csviri
Copy link
Collaborator Author

csviri commented Nov 20, 2024

If this is merged, I will do a separate PR that improved on the API, namely that SecondaryToPrimary mapper will have a setter for primary type, so it can be set under the hood, so user won't have to do it.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xstefank
Copy link
Collaborator

@csviri some rebase went wrong :)

@csviri
Copy link
Collaborator Author

csviri commented Nov 22, 2024

@csviri some rebase went wrong :)

This happens when we reabase new PRs on next, but after the next is rebased again on main. Then only trivial solution is just (squash+) cherry-pick commits on a new branch. Maybe would be good to sync when we do rebases of next on top of main. Ideally if there are no complex PRs targeting next. cc @metacosm

@csviri csviri self-assigned this Nov 22, 2024
@csviri
Copy link
Collaborator Author

csviri commented Nov 22, 2024

replaced by: #2606

@csviri csviri closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm Awaiting requested review from metacosm

@xstefank xstefank Awaiting requested review from xstefank

Assignees

@csviri csviri

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@csviri @openshift-merge-robot @xstefank @metacosm @10000-ki @matteriben @bachmanity1 @Donnerbart