Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<fix>: fix #1981 #1984

Merged
merged 2 commits into from
Jul 31, 2023
Merged

<fix>: fix #1981 #1984

merged 2 commits into from
Jul 31, 2023

Conversation

xiaoma20082008
Copy link
Contributor

fix #1981

@csviri
Copy link
Collaborator

csviri commented Jul 28, 2023

thx @xiaoma20082008

@csviri
Copy link
Collaborator

csviri commented Jul 28, 2023

@xiaoma20082008 could you pls run mvn clean install locally to format the code.

Also although imo this is gray area, would be nice to have a unit test. But just nice to have in this case.

@xiaoma20082008
Copy link
Contributor Author

@csviri ok, I'd run mvn clean install successfully ,and removed unused import packages.

csviri
csviri approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit 02777e3 into operator-framework:main Jul 31, 2023
17 checks passed
@csviri
Copy link
Collaborator

csviri commented Jul 31, 2023

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception found when use inherit in crd
2 participants
@xiaoma20082008 @csviri