-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reconciler: fix deletion wait and updater retry logic #380
reconciler: fix deletion wait and updater retry logic #380
Conversation
@joelanford Would this also need to go into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
@acornett21 The code bases are similar, but I can't remember if we have the same updater and wait for deletion logic there. |
d0e53cb
to
03f5a32
Compare
@joelanford ahh okay, I assumed this issue was coming from an operator, but now I see that stackrox has a direct dependencies on this lib. Just wanted to make sure we cover the bases. |
@joelanford note the unhappy linter... |
03f5a32
to
b6d580d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 85.06% 79.67% -5.40%
==========================================
Files 19 31 +12
Lines 1346 1958 +612
==========================================
+ Hits 1145 1560 +415
- Misses 125 310 +185
- Partials 76 88 +12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joe Lanford <[email protected]>
2ea8498
to
175bc01
Compare
Fixes #378