Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconciler: fix deletion wait and updater retry logic #380

Merged

Conversation

joelanford
Copy link
Member

Fixes #378

@acornett21
Copy link
Contributor

@joelanford Would this also need to go into operator-sdk directly as well?

Copy link
Member

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@joelanford
Copy link
Member Author

@acornett21 The code bases are similar, but I can't remember if we have the same updater and wait for deletion logic there.

@joelanford joelanford force-pushed the fix-updater-infinite-wait branch from d0e53cb to 03f5a32 Compare August 21, 2024 11:56
@acornett21
Copy link
Contributor

acornett21 commented Aug 21, 2024

@joelanford ahh okay, I assumed this issue was coming from an operator, but now I see that stackrox has a direct dependencies on this lib. Just wanted to make sure we cover the bases.

@porridge
Copy link
Member

@joelanford note the unhappy linter...

@joelanford joelanford force-pushed the fix-updater-infinite-wait branch from 03f5a32 to b6d580d Compare August 22, 2024 11:03
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (08ab7fb) to head (175bc01).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/internal/updater/updater.go 78.94% 2 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (175bc01). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (08ab7fb) HEAD (175bc01)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   85.06%   79.67%   -5.40%     
==========================================
  Files          19       31      +12     
  Lines        1346     1958     +612     
==========================================
+ Hits         1145     1560     +415     
- Misses        125      310     +185     
- Partials       76       88      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford force-pushed the fix-updater-infinite-wait branch from 2ea8498 to 175bc01 Compare September 4, 2024 12:15
@everettraven everettraven added this pull request to the merge queue Sep 4, 2024
Merged via the queue into operator-framework:main with commit 93eb5ef Sep 4, 2024
6 checks passed
@joelanford joelanford deleted the fix-updater-infinite-wait branch September 4, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator infinite loop on transient errors from kube API
5 participants