Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps #253

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Bump deps #253

merged 5 commits into from
Jan 11, 2024

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Jan 10, 2024

Fixes #248

@openshift-ci openshift-ci bot requested review from joelanford and porridge January 10, 2024 20:38
@ncdc
Start using bingo
9b58a9f 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc
Copy link
Member Author

ncdc commented Jan 10, 2024

Working on fixing go/bingo version issue

@ncdc ncdc force-pushed the bump-deps branch 2 times, most recently from 42c5771 to ffe62e2 Compare January 10, 2024 21:09
joelanford
joelanford reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can delete the tools/scripts/fetch script and anything in the Makefile that references it and the tools directory.

@ncdc
Copy link
Member Author

ncdc commented Jan 10, 2024

I couldn't figure out where that was coming from ... glad you knew! Will fix

@ncdc
Copy link
Member Author

ncdc commented Jan 10, 2024

Fixed in last commit

ncdc added 4 commits January 11, 2024 09:01
@ncdc
Update k8s, controller-runtime dependencies
aa2f218 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc
Switch golangci-lint to bingo
e867240 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc
Upgrade goreleaser, switch to bingo
6e201ec 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc
Remove tools dir/refs
a0d250e 
It's no longer needed now that we're using bingo.

Signed-off-by: Andy Goldstein <[email protected]>
@stevekuznetsov stevekuznetsov added this pull request to the merge queue Jan 11, 2024
Merged via the queue into operator-framework:main with commit c738039 Jan 11, 2024
5 of 6 checks passed
joelanford
joelanford reviewed Jan 11, 2024
View reviewed changes
pkg/manager/namespace_test.go
Comment on lines -93 to -94
By("configuring WATCH_NAMESPACE with the namespaces of the watched pods")
ConfigureWatchNamespaces(&opts, log)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this dropped intentionally? Seems like we need to call it to make sure it correctly configures the options based on the env.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't intentional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#270

@ncdc ncdc mentioned this pull request Jan 11, 2024
Closed
@acornett21
Copy link
Contributor

@ncdc ncdc mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@porridge porridge Awaiting requested review from porridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update controller-runtime, k8s versions
4 participants
@ncdc @acornett21 @joelanford @stevekuznetsov