-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 updates to enable autogenerated demo, hosted out-of-tree #212
🌱 updates to enable autogenerated demo, hosted out-of-tree #212
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 39.58% 39.58%
=======================================
Files 8 8
Lines 485 485
=======================================
Hits 192 192
Misses 272 272
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Do you think it would be worth it for the sake of the git repo size to delete the demo gif and replace it with a link to an asciicinema? It won't remove the sizes of the previous revisions of the git from the repo's history, but it would stop us from additional increases. |
I'm +1 for moving to asciinema linked demos. It looks like the I'm sure we could implement some form of automated demo updates using that flag and a script that runs through the demo. |
The only reason that we don't do something like that is because we can't control the hygiene of the link. Maybe I'm overly concerned with the idea of having a stale link in an alpha release. |
I'm not sure what you mean about link hygiene? |
What's the retention policy on asciinema.org? If we have a link to content there, how do we keep it from expiring? |
I've never seen one expire. If one does, it's presumably for some old demo that's no longer up to date and/or relevant. |
From the This installation of asciinema recorder hasn't been linked to any asciinema.org
account. All unclaimed recordings (from unknown installations like this one)
are automatically archived 7 days after upload.
If you want to preserve all recordings made on this machine, connect this
installation with asciinema.org account by opening the following link: This imposes a requirement that there is an associated account for any updated demos, presumably associated with the repo/org. I'm checking to see if one exists, because I'd prefer to have a better bus factor. |
Signed-off-by: Jordan Keister <[email protected]>
96d157e
to
03eb16d
Compare
@ncdc, @everettraven re-implemented this PR as a step toward automating demo generation. Please take another look. |
Signed-off-by: Jordan Keister <[email protected]>
This PR was originally just bringing the in-repo animated gif demo up-to-date w.r.t. API changes, as it had lagged behind.
Based on feedback, it's rejiggered to provide the functional basis for automating the demo and hosting the resulting file at asciicast.org.
There will need to be follow-on PRs for workflow automation and updating the readme with generated demos.