Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 replace e2e Job with client-go ProxyGet() call #210

Merged
merged 1 commit into from
Nov 8, 2023
Merged

🌱 replace e2e Job with client-go ProxyGet() call #210

merged 1 commit into from
Nov 8, 2023

Conversation

everettraven
Copy link
Collaborator

Description:

  • Replaces the Job created to query the catalogd http server with a client-go ProxyGet() call to directly query the service. It parses the necessary information from the status.contentURL field of the Catalog resource before making the query.

Motivation:

@everettraven everettraven requested a review from a team as a code owner November 8, 2023 15:41
@ncdc ncdc added this pull request to the merge queue Nov 8, 2023
Merged via the queue into operator-framework:main with commit ca0bc34 Nov 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@ncdc ncdc ncdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tech Debt: Don't use a Job to fetch catalog contents from HTTP server in e2e
3 participants
@everettraven @ncdc @joelanford