Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(quarkus): Bump quarkus version to 3.15 #150

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

hauptmedia
Copy link
Contributor

Related to camunda/camunda-bpm-platform#4580

Backported commit 64274723bb from the camunda-bpm-platform repository.
Original author: Joaquín [email protected]

Related to camunda/camunda-bpm-platform#4580

Backported commit 64274723bb from the camunda-bpm-platform repository.
Original author: Joaquín <[email protected]>
@hauptmedia
Copy link
Contributor Author

This fails with the error messagea: Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project operaton-bpm-quarkus-engine: Fatal error compiling: java.lang.IllegalStateException: This module is configured to use @ConfigMapping annotations but we found a @ConfigRoot without a corresponding @ConfigMapping annotation in: org.operaton.bpm.quarkus.engine.extension.OperatonEngineConfig. Either add the annotation or add the -AlegacyConfigRoot=true argument to the annotation processor config in the pom.xml -> [Help 1]
Should we enable the legacyConfigRoot Option? What do you think @kthoms?

@javahippie
Copy link
Contributor

@hauptmedia There is a commit missing, the @ConfigMapping was added in the bump to quarkus 3.14 here:

camunda/camunda-bpm-platform@816b58f

@hauptmedia
Copy link
Contributor Author

@javahippie good catch, will fix this

@javahippie
Copy link
Contributor

I'm not sure how much effort it is to merge those together, if you backport the referenced commit with the porting-tool, I can merge that one first and a rebase on this branch should resolve the issue

@hauptmedia
Copy link
Contributor Author

the porting tool cannot do it fully automatically, so i will just add the patch file manually to this branch. No big deal. I'm now quite experienced doing this stuff 😂😂

Related-to: camunda/camunda-bpm-platform#4163

Backported commit 816b58f from the camunda-bpm-platform repository.
Original author: Joaquín <[email protected]>"
@hauptmedia
Copy link
Contributor Author

hauptmedia commented Nov 6, 2024

i skipped the 3.14 commit because i thought it's a simple version bump that is superseeded by the next version bump. But that is not always the case. Every commit has to be check. I noted every commit I skipped, will check all again if I missed something

@javahippie javahippie merged commit 9e3c615 into operaton:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants