Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump lib versions #1314

Closed
wants to merge 1 commit into from
Closed

bump lib versions #1314

wants to merge 1 commit into from

Conversation

qrkourier
Copy link
Member

adopt the router extend patch

@qrkourier qrkourier requested review from a team as code owners September 18, 2023 14:25
@qrkourier qrkourier force-pushed the router-extend-bump-edge branch 3 times, most recently from 2f1b53e to 000e86c Compare September 18, 2023 16:45
@qrkourier qrkourier changed the base branch from release-next to fix-create-config-tests September 18, 2023 18:27
Base automatically changed from fix-create-config-tests to release-next September 18, 2023 18:31
@qrkourier qrkourier force-pushed the router-extend-bump-edge branch 6 times, most recently from 3b284d7 to 3bc138d Compare September 20, 2023 23:07
andrewpmartinez
andrewpmartinez requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@andrewpmartinez andrewpmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title indicates an edge version bump, but I do not see an update go.mod nor go.sum file that would indicate the dep version was changed.

Was this just to generate the changelog?

@qrkourier
Copy link
Member Author

Thanks for the review. The original goal was only to bump the edge version. Along the way, I learned that we typically bump all libraries with a procedure like this.

Now I've run that script to refresh all library versions.

@qrkourier qrkourier changed the title bump edge version bump lib versions Sep 26, 2023
@plorenz
Copy link
Member

plorenz commented Sep 30, 2023

superceded by #1361 which needed to update deps as well.

@plorenz plorenz closed this Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpmartinez andrewpmartinez Awaiting requested review from andrewpmartinez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qrkourier @plorenz @andrewpmartinez