Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart function env race condition #1282

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

qrkourier
Copy link
Member

rebuild the env file atomically

@qrkourier qrkourier requested review from a team as code owners August 31, 2023 20:34
@qrkourier qrkourier changed the base branch from release-next to quickstart-function-wait-router August 31, 2023 20:35
Copy link
Member

@dovholuknf dovholuknf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the atomic update/creation of the file. seems like a nice improvement.

Base automatically changed from quickstart-function-wait-router to release-next September 1, 2023 16:23
@qrkourier qrkourier merged commit 916d07c into release-next Sep 1, 2023
18 checks passed
@qrkourier qrkourier deleted the quickstart-function-env-race-condition branch September 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants