Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC timeout ext auth #749

Merged
merged 2 commits into from
Oct 10, 2024
Merged

OIDC timeout ext auth #749

merged 2 commits into from
Oct 10, 2024

Conversation

ekoby
Copy link
Member

@ekoby ekoby commented Oct 10, 2024

this fixes blocking of future auth flows if user fails to complete authenticatication

this what will be in the log

(59389)[      310.102]    WARN ziti-sdk:oidc.c:434 ext_accept() redirect_uri was not called in time
(59389)[      310.385]    WARN ziti-sdk:oidc.c:259 failed_auth_req() OIDC authorization failed: Operation timed out
(59389)[      310.385]    WARN ziti-sdk:external_auth.c:93 ext_token_cb() failed to get external authentication token: -14/failed to authenticate

@ekoby ekoby requested a review from a team as a code owner October 10, 2024 15:32
smilindave26
smilindave26 reviewed Oct 10, 2024
View reviewed changes
library/ziti.c
return;
}

ztx->config.id.oidc = calloc(1, sizeof(*oidc));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you clean this (and the strdups) up, or it it leaky?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ztx->config is cleaned up when it is closed

@ekoby ekoby merged commit 6c07128 into release-stable Oct 10, 2024
15 checks passed
@ekoby ekoby deleted the oidc-timeout-ext-auth branch October 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smilindave26 smilindave26 smilindave26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekoby @smilindave26