Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install contemporary git and clang #22

Merged
merged 3 commits into from
Sep 12, 2023
Merged

install contemporary git and clang #22

merged 3 commits into from
Sep 12, 2023

Conversation

qrkourier
Copy link
Member

resolves #5

docker-image/Dockerfile Outdated Show resolved Hide resolved
docker-image/Dockerfile Outdated Show resolved Hide resolved
@ekoby
Copy link
Member

ekoby commented Aug 22, 2023

couple more tools:

  • clang-tidy (from llvm repo)
  • cppcheck
  • gcov

@qrkourier
Copy link
Member Author

  • gcov

@ekoby gcovr?

@ekoby
Copy link
Member

ekoby commented Aug 22, 2023

  • gcov

@ekoby gcovr?

I guess gcov is part of gcc install. gcovr would be useful to generate readable reports

@qrkourier
Copy link
Member Author

Relevant discussion about sticking with gcc v7 on Bionic vs compiling gcc v11 or v13 from source in this thread: #5 (comment)

@qrkourier qrkourier requested a review from ekoby August 22, 2023 19:12
@qrkourier
Copy link
Member Author

I pushed this branch's local container image build to docker.io/kbinghamnetfoundry/ziti-builder:latest and tested the ZET's main cmake.yml workflow here: https://github.com/openziti/ziti-tunnel-sdk-c/actions/runs/5931869807?pr=716

@@ -80,6 +113,21 @@ RUN cd /usr/local \
&& ./vcpkg/bootstrap-vcpkg.sh -disableMetrics \
&& chmod -R ugo+rwX /usr/local/vcpkg

# RUN cd /usr/local/src \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could run these build steps (and any apt installs that are only needed for gcc) in a stage and then COPY the install directory into the final stage of this image. This makes cleanup perfect and effortless.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that will eliminate any compilation-related bloat in the final image, if we decide to go the route of compiling the three gcc v11 or v13 suites for native, cross-arm, cross-arm64.

@qrkourier qrkourier merged commit 3abfaf9 into main Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update some tools in the builder image
3 participants