Upgrade node-gyp to latest (10.1.0) to enable macOS arm builds #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
upgrade-node-gyp
branch
from
154591b to
1dfbc35
Compare
kelson42
force-pushed
the
upgrade-node-gyp
branch
from
1dfbc35 to
8055213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the help and READMEs of
node-gyppoint to always upgrading to the latest version before reporting bugs. With the current version of 9.3.1, on my ARM macbook running 14.5, I got some cryptic build failure about "cflagss". With thenode-gypversion updated, it appears to build fine and tests pass.