Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto deleting books #84

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Auto deleting books #84

merged 2 commits into from
Jul 18, 2022

Conversation

fadiga
Copy link
Collaborator

@fadiga fadiga commented Jul 11, 2022

close #71

@fadiga fadiga added this to the M2 milestone Jul 11, 2022
@fadiga fadiga self-assigned this Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #84 (01b2620) into main (efb960d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 01b2620 differs from pull request most recent head 107f916. Consider uploading reports for the commit 107f916 to get more accurate results

@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          467       491   +24     
=========================================
+ Hits           467       491   +24
Impacted Files Coverage Δ
backend/src/backend/constants.py 100.00% <100.00%> (ø)
backend/src/backend/routes/books.py 100.00% <100.00%> (ø)
backend/src/backend/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb960d...107f916. Read the comment docs.

@fadiga fadiga requested a review from rgaudin July 11, 2022 18:06
rgaudin
rgaudin requested changes Jul 12, 2022
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ; please see inline comments

rgaudin
rgaudin reviewed Jul 12, 2022
View reviewed changes
@fadiga fadiga requested a review from rgaudin July 18, 2022 15:12
rgaudin
rgaudin requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@fadiga fadiga requested a review from rgaudin July 18, 2022 15:29
rgaudin
rgaudin approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK ; let's rebase

@rgaudin rgaudin merged commit 7f64e02 into main Jul 18, 2022
@rgaudin rgaudin deleted the issue71 branch July 18, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@fadiga fadiga

Labels
None yet
Projects
None yet
Milestone
M2
Development

Successfully merging this pull request may close these issues.

Auto deleting books
2 participants
@fadiga @rgaudin