Workaround issue of Linux vdev_disk.c #16678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some cases not linearizing buffers with disk sector crossing a page boundary. It is fine for hardware, but somehow required by LUKS. It is not typical for ZFS to produce such buffers, but it may happen if 6KB block is compressed to 4KB, while still having 2KB alignment. Banning the 6KB buffers helps vdevs with ashifh=12. Signed-off-by: Alexander Motin <[email protected]> Sponsored by: iXsystems, Inc.
tonyhutter
approved these changes
Oct 23, 2024
This was referenced Oct 23, 2024
mcmilk
approved these changes
Oct 23, 2024
|
There is a typo in the comment:
|
You are right, within the comment :-( |
Another reason to remove all the workaround sooner. ;) |
robn
added a commit
to robn/zfs
that referenced
this pull request
Oct 25, 2024
Now that we can handle these different alignments, we don't this workaround. This reverts commit aefc2da. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
13 tasks
robn
added a commit
to robn/zfs
that referenced
this pull request
Oct 26, 2024
Now that we can handle these different alignments, we don't this workaround. This reverts commit aefc2da. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
robn
added a commit
to robn/zfs
that referenced
this pull request
Oct 26, 2024
Now that we can handle these different alignments, we don't this workaround. This reverts commit aefc2da. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
robn
added a commit
to robn/zfs
that referenced
this pull request
Oct 27, 2024
Now that we can handle these different alignments, we don't this workaround. This reverts commit aefc2da. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <[email protected]>
Merged
13 tasks
behlendorf
pushed a commit
that referenced
this pull request
Nov 1, 2024
Now that we can handle these different alignments, we don't this workaround. This reverts commit aefc2da. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes #16687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some cases not linearizing buffers with disk sector crossing a page boundary. It is fine for hardware, but somehow required by LUKS. It is not typical for ZFS to produce such buffers, but it may happen if 6KB block is compressed to 4KB, while still having 2KB alignment. Banning the 6KB buffers helps vdevs with ashift=12.
Types of changes
Checklist:
Signed-off-by.