Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Fix zpool_reguid Makefile.am #16559

Merged
merged 1 commit into from
Sep 25, 2024
Merged

ZTS: Fix zpool_reguid Makefile.am #16559

merged 1 commit into from
Sep 25, 2024

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

CI warnings like the following:

vm2: Warning: TestGroup '/var/tmp/tests/functional/cli_root/zpool_reguid' not added to this run.
Auxiliary script '/var/tmp/tests/functional/cli_root/zpool_reguid/setup' failed verification.

https://github.com/openzfs/zfs/actions/runs/10984039485/job/30500104089

Description

The zpool_reguid tests were not being included the dist tarball resulting in them not running. This is reported as a "failed verification" warning by the CI. Add the tests to the correct Makefile.am.

@mcmilk @jwk404 what do you think about converting this to a fatal error. Or if we leave it a warning have the CI report it. This kind of thing has snuck through a few too many times for my liking.

How Has This Been Tested?

Will be verified by the CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Sep 23, 2024
@behlendorf behlendorf force-pushed the zts-zpool_reguid branch 2 times, most recently from 1d6e059 to e0c5ec6 Compare September 25, 2024 00:42
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 25, 2024
@behlendorf
ZTS: Fix zpool_reguid Makefile.am and tests
b029d21 
The zpool_reguid tests were not being included the dist tarball
resulting in them not running.  This is reported as a "failed
verification" warning by the CI.  Add the tests to the correct
Makefile.am.

Additionally, remove the usage of 'bc -e <expr>' from the tests.
This option is only supported by the FreeBSD version of bc.

Update the test case to reflect the 0 is not a valid GUID.

Signed-off-by: Brian Behlendorf <[email protected]>
@mcmilk
Copy link
Contributor

mcmilk commented Sep 25, 2024

@mcmilk @jwk404 what do you think about converting this to a fatal error. Or if we leave it a warning have the CI report it. This kind of thing has snuck through a few too many times for my liking.

Yes, it shoud be a fatal error. When I am back from vacation - I can submit a PR for it, if needed.

@behlendorf behlendorf merged commit b2ca510 into openzfs:master Sep 25, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmilk mcmilk mcmilk approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @mcmilk