CI: Move perl script to dist_noinst_DATA #15392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything listed in dist_noinst_SCRIPTS is assumed to be a shell scrip, this generates a shellcheck SC1071 error since perl is not supported. Move update_authors.pl to dist_noinst_DATA with the other perl scripts. Signed-off-by: Brian Behlendorf <[email protected]>
tonyhutter
approved these changes
Oct 10, 2023
robn
approved these changes
Oct 10, 2023
behlendorf
added
Status: Accepted
behlendorf
added a commit
that referenced
this pull request
Oct 11, 2023
Everything listed in dist_noinst_SCRIPTS is assumed to be a shell script, this generates a shellcheck SC1071 error since perl is not supported. Move update_authors.pl to dist_noinst_DATA with the other perl scripts. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Rob N <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #15392
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Everything listed in dist_noinst_SCRIPTS is assumed to be a shell script, this generates a shellcheck SC1071 error since perl is not supported. Move update_authors.pl to dist_noinst_DATA with the other perl scripts. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Rob N <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#15392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix my mistake from 000cfca which added the script to the wrong place in the makefile.
Description
Everything listed in dist_noinst_SCRIPTS is assumed to be a shell scrip, this generates a shellcheck SC1071 error since perl is not supported. Move update_authors.pl to dist_noinst_DATA with the other perl scripts.
How Has This Been Tested?
To be verified by the CI.
Types of changes
Checklist:
Signed-off-by.