Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkstyle: fix action failures #15220

Merged
merged 1 commit into from
Aug 29, 2023
Merged

checkstyle: fix action failures #15220

merged 1 commit into from
Aug 29, 2023

Conversation

sdimitro
Copy link
Contributor

Errors Silenced (other zed scripts did the same) - shellcheck:

cmd/zed/zed.d/statechange-slot_off.sh:26:7: warning: ZED_ZEDLET_DIR is referenced but not assigned. [SC2154]
make: *** [Makefile:7085: shellcheck-here-cmd^zed^zed.d^statechange-slot_off.sh] Error 1
make: *** Waiting for unfinished jobs....
cmd/zed/zed.d/statechange-slot_off.sh:34:7: warning: ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT is referenced but not assigned. [SC2154]
cmd/zed/zed.d/statechange-slot_off.sh:38:7: warning: ZEVENT_VDEV_STATE_STR is referenced but not assigned. [SC2154]
cmd/zed/zed.d/statechange-slot_off.sh:42:12: warning: ZEVENT_VDEV_ENC_SYSFS_PATH is referenced but not assigned. [SC2154]
cmd/zed/zed.d/statechange-slot_off.sh:48:1: warning: i appears unused. Verify use (or export if used externally). [SC2034]
cmd/zed/zed.d/statechange-slot_off.sh:51:2: warning: j appears unused. Verify use (or export if used externally). [SC2034]
cmd/zed/zed.d/statechange-slot_off.sh:52:15: note: Double quote to prevent globbing and word splitting. [SC2086]
cmd/zed/zed.d/statechange-slot_off.sh:52:58: warning: In POSIX sh, == in place of = is undefined. [SC3014]
cmd/zed/zed.d/statechange-slot_off.sh:59:13: note: Double quote to prevent globbing and word splitting. [SC2086]
cmd/zed/zed.d/statechange-slot_off.sh:63:64: warning: ZEVENT_VDEV_PATH is referenced but not assigned. [SC2154]

Errors Fixed - mancheck:

mandoc: ./man/man8/zpool.8:113:100: STYLE: input text line longer than 80 bytes: Converts a non-redun...
mandoc: ./man/man8/zpool.8:114:2: WARNING: skipping no-space macro
mandoc: ./man/man8/zpool.8:268:67: STYLE: no blank before trailing delimiter: No Making a non-mirrored ZFS Storage Pool mirrored.
make: *** [Makefile:7239: mancheck] Error 1

@sdimitro
checkstyle: fix action failures
322ca65 
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
@sdimitro sdimitro marked this pull request as ready for review August 29, 2023 15:51
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 29, 2023
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 29, 2023
@behlendorf behlendorf merged commit cad00d5 into openzfs:master Aug 29, 2023
18 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 1, 2023
@sdimitro @behlendorf
checkstyle: fix action failures
ebdcb28 
Reviewed-by: Don Brady <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes openzfs#15220
behlendorf pushed a commit that referenced this pull request Sep 1, 2023
@sdimitro @behlendorf
checkstyle: fix action failures
63159e5 
Reviewed-by: Don Brady <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes #15220
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 11, 2023
@sdimitro @behlendorf
checkstyle: fix action failures
39347fc 
Reviewed-by: Don Brady <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes openzfs#15220
tonyhutter pushed a commit that referenced this pull request Sep 12, 2023
@sdimitro @tonyhutter
checkstyle: fix action failures
f1e67cc 
Reviewed-by: Don Brady <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes #15220
defaziogiancarlo pushed a commit to LLNL/zfs that referenced this pull request Sep 13, 2023
@sdimitro @defaziogiancarlo
checkstyle: fix action failures
d432f3f 
Reviewed-by: Don Brady <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes openzfs#15220
Signed-off-by: Gian-Carlo DeFazio <[email protected]>
(cherry-picked from commit 39347fc)
tonyhutter pushed a commit that referenced this pull request Sep 27, 2023
@sdimitro @tonyhutter
checkstyle: fix action failures
c8a3c74 
Reviewed-by: Don Brady <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes #15220
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@sdimitro @lundman
checkstyle: fix action failures
25995f9 
Reviewed-by: Don Brady <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes openzfs#15220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@don-brady don-brady don-brady approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdimitro @behlendorf @tonyhutter @don-brady