Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.2] linux: zfs: ctldir: set [amc]time to snapshot's creation property #15136

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[2.2] linux: zfs: ctldir: set [amc]time to snapshot's creation property #15136

merged 1 commit into from
Aug 2, 2023

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

A small, targeted, useful improvement which should be included in the 2.2 release.

Closes #15110
Closes #15117

Description

If looking up a snapdir inode failed, hold pool config – hold the snapshot – get its creation property – release it – release it, then use that as the [amc]time in the allocated inode. If that fails then fall back to current time. No performance impact since this is only done when allocating a new snapdir inode.

How Has This Been Tested?

Tested by the CI and original author.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

@nabijaczleweli @behlendorf
linux: zfs: ctldir: set [amc]time to snapshot's creation property
b3fefe4 
If looking up a snapdir inode failed, hold pool config – hold the 
snapshot – get its creation property – release it – release it, 
then use that as the [amc]time in the allocated inode. If that 
fails then fall back to current time. No performance impact since 
this is only done when allocating a new snapdir inode.
                                                       
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#15110
Closes openzfs#15117
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 1, 2023
@behlendorf behlendorf changed the title linux: zfs: ctldir: set [amc]time to snapshot's creation property [2.2] linux: zfs: ctldir: set [amc]time to snapshot's creation property Aug 1, 2023
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 2, 2023
@behlendorf behlendorf merged commit bd1eab1 into openzfs:zfs-2.2-release Aug 2, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @nabijaczleweli